[ขอคำแนะนำค่ะ] open popup window ตรงโค้ด js เขียนแบบนี้รึเปล่าคะ

<script type="text/javascript" language="javascript" src="../js/popup.js"></script>

		echo"<tr>
		<td align=\"center\">$rs[id]</td>
		<td>$rs[name]</td>
		<td align=\"center\"><a href=\"javascript:popup_details('view.php?id=$rs[id]')\">คลิ๊กดูรายละเอียด</a></td>
		<td align=\"center\"><a href=\"javascript:popup_update('edit.php?id=$rs[id]')\">คลิ๊กแก้ไข</a></td>
		<td align=\"center\"><a href=\"javascript:popup_delete('delete.php?id=$rs[id]')\">คลิ๊กลบ</a></td>
		<td align=\"center\"><a href=\"$PHP_SELF?id=$rs[id]\"</a></td>
		</tr>";

	

function popup_details(URL){
	day = new Date();
	id = day.getTime();
	eval("page" +id+ "=window.open(url,"+id+",'toolbar=0,scrolbars=1,location=0,statusbar=0,menubar=0,resizable=0,width=400,height=250,left=362,top=134');");
}